Update mail.py - correct reference to replacement. #1900
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make this script usable again. this change added the ability to include this script again without touching all scripts that include this - like `owncloud-unlockadmin.sh`. I guess without this change those scripts would harm more than that it helps.
|
good catch |
|
It depends on where you run the script from. All of the scripts generally assume you're in the main mailinabox directory. |
hughsw
reviewed
Jan 19, 2024
| @@ -1,3 +1,3 @@ | |||
| #!/bin/bash | |||
| # This script has moved. | |||
| management/cli.py "$@" | |||
| ../management/cli.py "$@" | |||
There was a problem hiding this comment.
Suggested change
| ../management/cli.py "$@" | |
| $(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/../management/cli.py "$@" |
This solves the problem of cwd. I believe this is idiomatic bash for getting the directory in which a script resides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make this script usable again.
this change added the ability to include this script again without touching all scripts that include this - like
owncloud-unlockadmin.sh. I guess without this change those scripts would harm more than that it helps.