Try to print MTA-STS missing DNS policy error reason #1884
Conversation
|
Thanks for this. If the cert is missing or invalid, I think we can just skip the MTA-STS message entirely, since there will be a message about the certificate. |
When proper (not self-signed) TLS certificate is not provisioned on the domain yet, MiaB prints only: MTA-STS policy is missing: STSFetchResult.NONE which may confuse the administrator, as .well-known/mta-sts.txt file is already present and opens correctly. Print more human-friendly reason for this case.
ValdikSS
force-pushed
the
mta-sts-tls-error
branch
from
59fe2d4 to
ab7a5d4
Compare
|
Like this I guess? Please check. |
| if not cert: | ||
| certmessage = "No TLS certificate provisioned for this domain" | ||
| else: | ||
| cert_status = check_certificate(domain, cert['certificate'], cert['private-key']) | ||
| if cert_status[0] != 'OK': | ||
| certmessage = "TLS certificate is not valid" |
There was a problem hiding this comment.
I'm suggesting having no message (no call to output.print_error) in these two conditions.
There was a problem hiding this comment.
Do you want to remove these text messages completely or print them not as an error? If the second, how it should be printed?
There was a problem hiding this comment.
Remove completely. Sorry for the ambiguity.
There was a problem hiding this comment.
Feel free to edit this merge request as is suitable for the codebase. I'm no longer use MIAB actively and can't test my edit right now.
|
@JoshData, hello, any chance to get this merged? |
When proper (not self-signed) TLS certificate is not provisioned on the domain yet, MiaB prints only:
MTA-STS policy is missing: STSFetchResult.NONEwhich may confuse the administrator, as
.well-known/mta-sts.txtfile is already present and opens correctly.Print more human-friendly reason for this case.
Code taken from dns-update.py and slightly edited.