Review comments support

[itainoam]

Does forge currently support review comments (comments on a portion of the diff)?

If not, is there a plan to add it in the future?

[tarsius]

No. Yes.

[titaniumbones]

Ah man I'm so totally looking forward to this! Shout to starting marking 50 student assignments a week via code review :-/

[leungbk]

For the time being, this seems to be what you're looking for and can integrate with Forge: https://github.com/charignon/github-review

[nshi]

This would be a great feature. Is there any plan for adding it soon?

[tarsius]

Yes it would, but no.

[Fuuzetsu]

I don't suppose there's a way to make this issue prioritized, like financial donations &c.?

[tarsius]

I still have to create and send certain perks to kickstarter backers. Before that I can't really ask for more money. Doing that is getting really urgent and I don't want to tackle anything that takes a while even if it were to bring in some money.

[Fuuzetsu]

Understood, thank you.

[TonCherAmi]

@tarsius could you give us the current status on this? Is it still a low priority thing?

[tarsius]

It's a "it's gonna be a lot of work and I don't yet have the time for that" thing.

[TonCherAmi]

Got it, thanks. Would be awesome to see it at some point.

[Thaodan]

Are PR approves also part of that issue?

[iyefrat]

Substantial work is being done on this front with code-review. It's built on top of magit-section and transient, and has the explicit goal of supporting multiple forges. See here for the current supported feature list per forge. Perhaps this feature can just exist in a separate package, @wandersoncferreira seems to be aiming for basically all the features people want out of this (thanks for the great work man!)

[appetrosyan]

To anyone who stumbled across this like I did, the package is not currently installable and hasn't been updated since 2021.

[tarsius]

I've read that wandersoncferreira/code-review#246 makes that package usable again.