Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline comments #663

Closed
shindere opened this issue May 2, 2024 · 2 comments
Closed

Support for inline comments #663

shindere opened this issue May 2, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@shindere
Copy link
Contributor

shindere commented May 2, 2024

I think GitHub does have an API to submit inline comments to PRs, thatis,
comments that are tied to oneprecise portionn of code. This is something
that owuld be very clumsy to do with a CLItool, but with emacs and forge, it
feels it could be very simple to just mark a region and then run a comment
to submit a comment associated to this region.

Would that be doable?

Not being able to use the web UI for that, I suffer a lot from not
having a way to submit inline comments.

@tarsius
Copy link
Member

tarsius commented May 2, 2024

That's a feature that is frequently requested and I might eventually add support to Forge itself. There's an open issue about this: #75.

At least two separate packages exist that already implement this:

@tarsius tarsius added the duplicate This issue or pull request already exists label May 2, 2024
@tarsius tarsius closed this as completed May 2, 2024
@shindere
Copy link
Contributor Author

shindere commented May 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants