-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate code for X costs #12551
base: master
Are you sure you want to change the base?
Conversation
…rceCostsTag(game, $1, "X", 0) Fix Disrupting Shoal
… reduction that does not use X)
Looking good. |
Word of Command don't use X -- why you need to test it? Make sure all works with double X effects from [[Unbound Flourishing]] |
Unbound Flourishing - (Gatherer) (Scryfall) (EDHREC)
|
Unbound Flourishing has an extensive test suite, I'm confident that it works. However, I just noticed that the permanent X value doubling ability is implemented as a replacement effect instead of as a triggered ability like the card text demands. I'll make a new PR to fix that once I'm done here, should be pretty easy once this PR is merged and everything uses the costs tags system. (I don't want to add functional changes to cards in this PR.) |
Based on #12059 but expanded in scope to remove all duplicate ways of getting X values, combining them all into
GetXValue
. Notably this does not remove the ways of accessing variable costs that do not involve X, in particular for cost reduction effects.TODO before un-drafting: