Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: use aws-load-balancer-controller in front of ingress-nginx #293

Merged
merged 5 commits into from
May 26, 2022
Merged

enh: use aws-load-balancer-controller in front of ingress-nginx #293

merged 5 commits into from
May 26, 2022

Conversation

mglotov
Copy link
Contributor

@mglotov mglotov commented May 18, 2022 •
edited
Loading

PR Description

  • Enabled aws-load-balancer-controller by default
  • Changed ingress-nginx service type from LoadBalancer to ClusterIP by default
  • Disabled external-dns by default
  • Generated SSL certificates for aws-load-balancer-controller due to this issue
  • Updated FAQ.md with notes on how to terminate SSL on ingress-nginx side (use cert-manager)

New default scheme looks like:
image

Pros:

  • we can use WAF without using Cloudfront
  • we can use WebSockets

Cons:

  • can be used only for http traffic

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov marked this pull request as draft May 18, 2022 07:56
@mglotov mglotov marked this pull request as ready for review May 20, 2022 11:43
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit 6569044 into main May 26, 2022
@mglotov mglotov deleted the enh/alb-ingress branch May 26, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halfb00t halfb00t halfb00t approved these changes

@p1gmale0n p1gmale0n p1gmale0n approved these changes

@khalezin khalezin Awaiting requested review from khalezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mglotov @p1gmale0n @halfb00t