Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 support #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bfaliszek
Copy link

No description provided.

@maarten-pennings
Copy link
Owner

Hi, first time for me to work with the merge request tool, so be gentle with me :-)
I appreciate that you add support for ESP32, but I do have some doubts:

  • My style was to have one line of comment describing the hardware setup, and then (one line of) code for that setup. There were only two setups: ESP8266 and Nano. And the user has to use comments to select what he wants. This style is now broken. ESP8266 and ESP are automatically selected due the the #if's, but the Nano isn't. And the comment for the ESP is missing. This is inconsistent.

  • My drive for the examples is that they have to be easy (to understand), so short. The libs can be hard. Adding the #if's doesn't make it easy. On the other hand, the flash example is not really an example so we could go for not-easy-but-working-out-of-the-box. In that case, we would need #if's for e.g. Nano (and maybe others).

  • I was also looking at the other examples; they are really examples (so I want to "keep it simple"), so should this one be different?

@bfaliszek
Copy link
Author

I use your library with ESP32 and it works without a problem. The only difference compared to ESP8266 is the ability to define i2c pins. I have 4 different ESP32 boards and each has different pins, so I thought that the possibility of defining them would be very useful. In addition, I tested this firmware upload from ESP32 on... 125 CCS811 :D

When it comes to merge request or code formatting, you don't have to use my code at all. I just wanted to let you know that you can flash CCS811 with ESP32 and define any pin for i2c. It doesn't require any major code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants