-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An (incorrect) implementation for symbolic strong bisimulation #1736
Open
mlaveaux
wants to merge
19
commits into
mCRL2org:master
Choose a base branch
from
mlaveaux:feature/bisim-sigref
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaveaux
force-pushed
the
feature/bisim-sigref
branch
from
February 26, 2024 11:25
4106493
to
e1b064d
Compare
mlaveaux
force-pushed
the
feature/bisim-sigref
branch
from
March 12, 2024 16:49
863934c
to
464db06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is mostly a reminder to keep this branch alive and perhaps re-implement it after integrating OxiDD. Also to list the remaining issues.
Currently brp.mcrl2 shows an inconsistency between ltsconvert and ltsconvertsymbolic with a few hundred states. Ltsconvert claims the minimal bisimulation quotient to contain 293 states (which is most likely correct) whereas ltsconvertsymbolic finds a quotient with 337 states. Several other small examples show correct number of states. Also the implementation is far too slow to be applied to realistic examples, even 1394-fin.mcrl2 takes significant time.