Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

[WIP] V2 #8

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] V2 #8

wants to merge 1 commit into from

Conversation

lambdaR
Copy link

@lambdaR lambdaR commented May 21, 2022

change generate.yml and bump version to 2.0.0 in package.json

Signed-off-by: Daniel Joudat [email protected]

@lambdaR lambdaR marked this pull request as draft May 21, 2022 12:25
@asim
Copy link
Member

asim commented May 21, 2022

Before you do this can you make sure the TS template matches the old one. I can see that the new generator does not have the same index template.

@lambdaR
Copy link
Author

lambdaR commented May 21, 2022

(re-posted here to keep tracking)

i have noticed that some services are missing in the index.ts file at m3o/m3o-js .... namely Analytics and Wordle !! ... the last time index.ts file has been changed is 3 months ago ... beside that, the only diff i have seen between the two generated files (index.ts) is in the old gen export default (token: string = process.env.M3O_API_TOKEN) => and the new gen export default (token = process.env.M3O_API_TOKEN as string) => that's probably the effect of running prettier ... as for their templates i don't see any diff ... I`am comparing these two templates, the old and the new

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants