Apply suggestions from code review

Co-authored-by: scoder <[email protected]>
lysnikolaou · Aug 5, 2024 · 29132a6 · 29132a6
1 parent e94c168
commit 29132a6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Cython/Compiler/ExprNodes.py b/Cython/Compiler/ExprNodes.py
@@ -3130,6 +3130,7 @@ def generate_next_sequence_item(self, test_name, result_name, code):
             f"{result_name} = {getitem}({self.py_result()}, {self.counter_cname}); "
             f"{incref}({result_name}); "
             f"{self.counter_cname}{inc_dec}; "
+            # Use the error label to avoid C compiler warnings if we only use it below.
             f"{code.error_goto_if_neg('0', self.pos)}")
         code.putln("#else")
         code.putln(

diff --git a/Cython/Utility/ModuleSetupCode.c b/Cython/Utility/ModuleSetupCode.c
@@ -1059,7 +1059,7 @@ static CYTHON_INLINE PyObject * __Pyx_PyDict_GetItemStrWithError(PyObject *dict,
 #if CYTHON_ASSUME_SAFE_MACROS
 #define __Pyx_PyList_GetItemRef(o, i) __Pyx_NewRef(PyList_GET_ITEM(o, i))
 #else
-#define __Pyx_PyList_GetItemRef(o, i) __Pyx_NewRef(PyList_GetItem(o, i))
+#define __Pyx_PyList_GetItemRef(o, i) PySequence_GetItem(o, i)
 #endif
 
 static CYTHON_INLINE int __Pyx_PyDict_GetItemRef(PyObject *dict, PyObject *key, PyObject **result) {