-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature / Changes to make easier levels [44] #61
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t try running this version of the code, but after reading the code, I had some suggestions. (I am not an official hello wordl developer, just another user.)
@@ -147,6 +173,8 @@ function App() { | |||
> | |||
{ | |||
[ | |||
`Guesses don't even need to be real words.`, | |||
`Guesses must be valid dictionary words. Easy mode.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s describe what exactly makes this “easy mode”.
`Guesses must be valid dictionary words. Easy mode.`, | |
`Guesses must be valid dictionary words. Easy mode – the target word will be a common word.`, |
@@ -29,12 +29,14 @@ interface GameProps { | |||
keyboardLayout: string; | |||
} | |||
|
|||
const easyTargets = targetList.slice(0, targetList.indexOf("revel") + 1); // Slightly more frequent word on the list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“revel” is currently on line 14279 of the wordlist, while “murky” is on line 14502. I don’t think removing 223 possible words out of 14501 will produce a noticeable difference in difficulty. How about halving the search space by splitting on a word around line 7000?
src/App.tsx
Outdated
| ||
<strong> | ||
{["Baby", "Easy", "Normal", "Hard", "Ultra Hard"][difficulty]} | ||
</strong> | ||
<strong>{["Normal", "Hard", "Ultra Hard"][difficulty]}</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried this, but I think this line with the 3 old difficulty values is probably a mistake. As the line above has the new 5. So I guess this line will show them twice in the modes > Easy.
By the way, I guess the
4 lines above was not needed before, and I guess is still not needed. Or does this solve a separate issue?
…iguous[feature request 44' Co-authored-by: Rory O’Kane <[email protected]>
Fixes #44 Baby mode allows you to use non words, easy splices at 'revel'.