Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render_annotation fixed #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

render_annotation fixed #34

wants to merge 1 commit into from

Conversation

pyaf
Copy link

@pyaf pyaf commented Sep 17, 2019

Fixed #33
Changes:

  1. Little modification with a code comment. (L1065).
  2. Removed a redundant line (L1066).
  3. Removed for loop, as there will be only one box for a given annotation token.
  4. Added title to LIDAR view plot.

@pyaf
Copy link
Author

pyaf commented Sep 17, 2019

Also, signed the CLA.

lopuhin
lopuhin reviewed Sep 21, 2019
View reviewed changes
lyft_dataset_sdk/lyftdataset.py
axes[0].set_ylim([np.min(corners[1, :]) - margin, np.max(corners[1, :]) + margin])
axes[0].axis("off")
axes[0].set_aspect("equal")
box = boxes[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be great to add an assert or write in a way that will fail in case there are more than one boxes, e.g.

Suggested change
box = boxes[0]
box, = boxes

and same with removing the loop below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopuhin lopuhin lopuhin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A small issue in render_annotation function
2 participants
@pyaf @lopuhin