Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security.py #211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update security.py #211

wants to merge 1 commit into from

Conversation

Blyth0He
Copy link

@Blyth0He Blyth0He commented May 8, 2024

preventing false positive by checking ADS_RIGHT_DS_CONTROL_ACCESS bit flag,
before this commit, there might false positve, when an ace has Enroll uuid without ADS_RIGHT_DS_CONTROL_ACCESS being set in Mask field, this happens when we unselect the checkbox which indicate the permission is allow or denied
image
before we uncheck the checkbox, we have CR(which means control access righ ) set on mask field, and the Enroll is also showed in the ace
image
if we uncheck the checkbox
image
we can find the CR flag is not set while the Enroll permission uuid still showed in the ace
image
when this happens, certipy still mark this cert template as "user can enroll", but actually it will be denied.
image

preventing false positive by checking ADS_RIGHT_DS_CONTROL_ACCESS bit flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant