feat: add vertically centered versions of themes #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodism
reviewed
Jun 16, 2024
src/logic/Preferences.swift
Outdated
| case windows10 = "1" | ||
| case macOsCentered = "1" | ||
| case windows10 = "2" | ||
| case windows10Centered = "3" |
There was a problem hiding this comment.
It seems people who currently have windows10 will end up with macOsCentered.
There was a problem hiding this comment.
Oops. Good catch. Just fixed that.
|
I think it's not a good idea to add the app position option to the theme. It should be considered a standalone option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vertically centered versions of both the MacOS and Windows themes to address issue #585