Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/shipping min quantity factor #1961

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from

Conversation

wychoong
Copy link
Contributor

@wychoong wychoong commented Sep 19, 2024

changes:

  • min_quantity now check on shipping method to determine should it divide by currency factor
  • min_quantity field label now reflect according to method
  • move min_quantity as last field
  • now assume weight is by KG

after
image

image

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 5:18am

@maurice-ellis
Copy link
Contributor

Don't assume weight, we are imperial in the US

@wychoong
Copy link
Contributor Author

Don't assume weight, we are imperial in the US

the focus of this PR is on the shipping method chargeBy is not considered when converting min_quantity

to properly calculate shipping cost for chargeBy weight requires more effort and should be a separate PR

@wychoong
Copy link
Contributor Author

changed it back to min_quantity / 100 for weight so that it is same as previous behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants