Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lsp4 uploads and network selection #156

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

JeneaVranceanu
Copy link
Member

@JeneaVranceanu JeneaVranceanu commented May 29, 2024

  • dApp continues to use lsp-factory which uses old IPFS URL. All uploads, specifically LSP4Metadata, failed;
  • network switching didn't work when selected network was Lukso Mainnet.

Example of an issue with LSP4 metadata AFTER the fix. Still images are not uploaded correctly. In the currently deployed version nothing uploads to IPFS at all.
Screenshot 2024-05-30 at 10 57 46

@richtera richtera force-pushed the fix/lsp4-upload-and-network-selection branch from f792071 to 8feed35 Compare November 1, 2024 14:52
Copy link
Contributor

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this as well. Maybe we can look at these two on Monday so we can finally merge them. I am assuming this is all fine.

Copy link

github-actions bot commented Nov 4, 2024

@richtera richtera force-pushed the fix/lsp4-upload-and-network-selection branch from 4df6378 to 37b95ca Compare November 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants