fix ESM types

[benmccann]

closes #199

[lukeed]

For all modules, please make these changes:

• TS says its requires "types" to be first
• Rename "." -> "default" & order it after "types"
• Rename index.d.ts as index.d.mts
• Add new index.d.ts which is the CommonJS export DTS file (to match "exports" description)

Suggested change

	"import": {
	".": "./build.mjs",
	"types": "./index.d.mts"
	},
	"require": {
	".": "./build.js",
	"types": "./index.d.ts"
	}
	"import": {
	"types": "./index.d.mts",
	"default": "./build.mjs"
	},
	"require": {
	"types": "./index.d.ts",
	"default": "./build.js"
	}

[benmccann]

Thanks for the quick review Luke! I've made the package.json changes you suggested. I'm not sure I understand the last bullet point or how it's different from what exists. Are you suggesting to use export = in case the user has esModuleInterop: false?

Any chance you'd consider dropping the CJS build? 😉

[lukeed]

Are you suggesting to use export =

Yes, to lean into the CommonJS TS definitions, rather than relying on tsc's implicit conversion

Any chance you'd consider dropping the CJS build? 😉

No

[benmccann]

Ok, I just pushed that change. I don't have a lot of experience with that style. I spent like an hour tying to find documentation and examples for it and it's not used much as far as I could see. Hopefully I did it correctly. If I'm way off base I think we could just revert the last commit. I feel it's a bit out of scope to update the types for CJS users and we could probably leave them as is in this PR. I was really just trying to get the ESM types updated, which I'm a lot more familiar with.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84b50d0) 100.00% compared to head (dc55f67) 100.00%.

❗ Current head dc55f67 differs from pull request most recent head 8400ea3. Consider uploading reports for the commit 8400ea3 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##              next      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          204       204           
=========================================
  Hits           204       204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lukeed]

Thanks Ben :)

The last remaining changes I took care of were:

• updating the files lists for each package.json file so that any new *.d.mts files would actually be sent to npm
• wrapping the CommonJS exports into a namespace so that no exported types were lost
• Point ESM/CJS types to the same file if & when the module only has named exports. Publint may still print a warning in this case, but that's fine :) CJS <-> ESM interop is totally fine when dealing with named exports only.

Sorry for the delay. Thanks for the work, patience, and ping!

[lukeed]

Released in the next.24 batch

[benmccann]

thank you Luke!!!