Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: allow assigning initialPossibleTypesMap for SSR use cases #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackyef
Copy link

@jackyef jackyef commented Apr 17, 2020

Hi, awesome library here! This library helped us to fetch instropection data on runtime to avoid loading them upfront on initial load.

We found that there is an issue when doing SSR. The SSR works and we can inject the serialised cache to the client side properly. But, upon hydrating, it seems like the client fails because it doesn't actually know about the possibleTypes information yet. We believe this is because the possibleTypes is still empty on the client side.

This PR adds a way to give an initialPossibleTypesMap to the fragment matcher.

@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files           3        3           
  Lines          83       83           
  Branches       16       17    +1     
=======================================
  Hits           82       82           
  Misses          1        1           
Impacted Files Coverage Δ
src/fragmentMatcher.js 97.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3110aa3...5092aa0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants