Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改了 Dockerfile 文件 | Modified Dockerfile #932

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

findlayfeng
Copy link

@findlayfeng findlayfeng commented Jul 2, 2024

  • 修改了运行时依赖的处理方式,通过对 PHP插件的库连接情况自动处理保留的包
  • PHP 的默认的配置文件通过link的方式链接到 production 文件
  • 修改了 apache 的默认 root 文件夹和其他环境做统一
  • 通过版本 环境变量SMARTY_VERSION 安装不同版本的 SMARTY
  • 通过 Multi-stage builds 的方式构建镜像
  • 删除了 .dockerignore 文件 通过 INSTALL_PATHS 变量的方式指定需要发布的路径,好处是添加了新的路径后需要显式的添加到发布列表,而不是默认发布,这个文件 5年没有修改了,显然的将不少不必要的文件发布到了docker镜像

  • Modified the handling of runtime dependencies, automatically handling the retained packages by checking the library connection of the PHP plugin
  • PHP's default configuration file is linked to the production file through link
  • Modified the default root folder of apache to unify with other environments
  • Install different versions of SMARTY through the version environment variable SMARTY_VERSION
  • Build images through Multi-stage builds
  • Deleted .dockerignore file The path to be published is specified through the INSTALL_PATHS variable. The advantage is that after adding a new path,
    it needs to be explicitly added to the release list instead of being published by default. This file has not been modified for 5 years. Obviously, many unnecessary files are published to the docker image.

@davidcoutadeur
Copy link

That's quite a big change.
I have planned to make a review of this next week.

@findlayfeng findlayfeng force-pushed the docker branch 4 times, most recently from d79c822 to 98bd76a Compare July 5, 2024 07:58
* Modified the handling of runtime dependencies,
automatically handling the retained packages by checking the library connection of the PHP plugin
* PHP's default configuration file is linked to the production file through link
* Modified the default root folder of apache to unify with other environments
* Install different versions of SMARTY through the version environment variable SMARTY_VERSION
* Build images through Multi-stage builds
* Deleted .dockerignore file The path to be published is specified through the INSTALL_PATHS variable.
The advantage is that after adding a new path,
it needs to be explicitly added to the release list instead of being published by default.
This file has not been modified for 5 years. Obviously, many unnecessary files are published to the docker image.

Signed-off-by: 冯诚 <[email protected]>
Use “RUN --mount=type=cache“ to cache apt
Fix changes from ltb-project#831
Remove duplicate dependencies

Signed-off-by: 冯诚 <[email protected]>
Signed-off-by: 冯诚 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants