Improvement of the prm for a generic camera #12
ziotom78Annotations
1 error and 3 warnings
|
code-style
Process completed with exit code 1.
|
|
code-style:
src/scanning.jl#L610
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
src/scanning.jl:610:-function genpointings!(wheelanglesfn,
src/scanning.jl:611:- beam_dir,
src/scanning.jl:612:- timerange_s,
src/scanning.jl:613:- t_start::Dates.DateTime,
src/scanning.jl:614:- skydirs,
src/scanning.jl:615:- skypsi;
src/scanning.jl:616:- polaxis = Float64[1.0, 0.0, 0.0],
src/scanning.jl:617:- latitude_deg = TENERIFE_LATITUDE_DEG,
src/scanning.jl:618:- longitude_deg = TENERIFE_LONGITUDE_DEG,
src/scanning.jl:619:- height_m = TENERIFE_HEIGHT_M,
src/scanning.jl:620:- precession = true,
src/scanning.jl:621:- nutation = true,
src/scanning.jl:622:- aberration = true,
src/scanning.jl:623:- refraction = true,
src/scanning.jl:624:- telescope_ang::Union{TelescopeAngles, Nothing} = nothing,
src/scanning.jl:625:- wheels_conf = TelescopeWheelConfig())
src/scanning.jl:631:+function genpointings!(
src/scanning.jl:632:+ wheelanglesfn,
src/scanning.jl:633:+ beam_dir,
src/scanning.jl:634:+ timerange_s,
src/scanning.jl:635:+ t_start::Dates.DateTime,
src/scanning.jl:636:+ skydirs,
src/scanning.jl:637:+ skypsi;
src/scanning.jl:638:+ polaxis = Float64[1.0, 0.0, 0.0],
src/scanning.jl:639:+ latitude_deg = TENERIFE_LATITUDE_DEG,
src/scanning.jl:640:+ longitude_deg = TENERIFE_LONGITUDE_DEG,
src/scanning.jl:641:+ height_m = TENERIFE_HEIGHT_M,
src/scanning.jl:642:+ precession = true,
src/scanning.jl:643:+ nutation = true,
src/scanning.jl:644:+ aberration = true,
src/scanning.jl:645:+ refraction = true,
src/scanning.jl:646:+ telescope_ang::Union{TelescopeAngles,Nothing} = nothing,
src/scanning.jl:647:+ wheels_conf = TelescopeWheelConfig(),
src/scanning.jl:648:+)
|
|
code-style:
test/scanning.jl#L129
[JuliaFormatter] reported by reviewdog 🐶
Raw Output:
test/scanning.jl:129:-(dirs, ψ) = genpointings(CameraAngles(),
test/scanning.jl:130:- times;
test/scanning.jl:131:- latitude_deg = TEST_TENERIFE_LATITUDE_DEG) do time_s
test/scanning.jl:132:- (0, deg2rad(20.0), Sl.timetorotang(time_s, spin_velocity))
test/scanning.jl:133:-end
test/scanning.jl:133:+(dirs, ψ) =
test/scanning.jl:134:+ genpointings(CameraAngles(), times; latitude_deg = TEST_TENERIFE_LATITUDE_DEG) do time_s
test/scanning.jl:135:+ (0, deg2rad(20.0), Sl.timetorotang(time_s, spin_velocity))
test/scanning.jl:136:+ end
|
|
code-style
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: julia-actions/setup-julia@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|