Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Reduce redundant autowires in server tests #8996

Merged
merged 11 commits into from
Jul 11, 2024
Merged

Development: Reduce redundant autowires in server tests #8996

merged 11 commits into from
Jul 11, 2024

Conversation

MaximilianAnzinger
Copy link
Contributor

@MaximilianAnzinger MaximilianAnzinger commented Jul 8, 2024 •
edited
Loading

Checklist

General

Motivation and Context

For testing we already use base classes that autowire some commonly used services. However, we often autowire the required service again in the integration test.

Description

This PR removes a lot of duplicated / unnecessary autowires.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@github-actions github-actions bot added the tests label Jul 8, 2024
@MaximilianAnzinger MaximilianAnzinger marked this pull request as ready for review July 9, 2024 09:14
@MaximilianAnzinger MaximilianAnzinger requested a review from a team as a code owner July 9, 2024 09:14
@MaximilianAnzinger MaximilianAnzinger added this to the 7.4.2 milestone Jul 9, 2024
@MaximilianAnzinger MaximilianAnzinger changed the title Development: Improve test code quality Development: Reduce redundant autowires in server tests Jul 9, 2024
JohannesStoehr
JohannesStoehr approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servertests are still successful. Looks good to me

egekurt123
egekurt123 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@egekurt123 egekurt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run successfully both locally and on github. Code LGTM

Strohgelaender
Strohgelaender approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The inconsistent names (repository vs repo) were always a problem when extending test classes, this got at least a bit easier now.

@krusche krusche merged commit b58e297 into develop Jul 11, 2024
39 of 41 checks passed
@krusche krusche deleted the chore/development/improve-test-code-quality branch July 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strohgelaender Strohgelaender Strohgelaender approved these changes

@JohannesStoehr JohannesStoehr JohannesStoehr approved these changes

@egekurt123 egekurt123 egekurt123 approved these changes

@JohannesWt JohannesWt Awaiting requested review from JohannesWt

@N0W0RK N0W0RK Awaiting requested review from N0W0RK

@Jan-Thurner Jan-Thurner Awaiting requested review from Jan-Thurner

Assignees

@MaximilianAnzinger MaximilianAnzinger

Labels
code quality ready to merge tests
Projects
Artemis Development
Status: Merged
Milestone
7.4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaximilianAnzinger @Strohgelaender @JohannesStoehr @egekurt123 @krusche