Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2043

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Update README.md #2043

merged 4 commits into from
Aug 27, 2024

Conversation

jtheletter
Copy link
Contributor

Add warning for data loss.

All submissions

Adding/updating Application X Support

  • This PR is only for one application
  • It has been added to the list of supported applications in the README
  • Changes have been added to the WIP section of the CHANGELOG
  • Syncing does not break the application
  • Syncing does not compete with any syncing functionality internal to the application
  • The configuration syncs the minimal set of data
  • No file specific to the local workstation is synced
  • No sensitive data is synced

Improving the Mackup codebase

  • My submission passes the tests
  • I have linted the code locally prior to submission
  • I have written new tests as applicable
  • I have added an explanation of what the changes do

Add warning for data loss.
@chrisbloom7
Copy link

Better than no notice at all I suppose, but unfortunately doesn't do anything to warn off existing users who assume it would continue to work as expected.

@chrisbloom7
Copy link

Perhaps it could mention the workaround that some folks have had success with.

@spuder
Copy link

spuder commented Aug 26, 2024

Please merge this.

It's gotten the attention of Reddit

https://www.reddit.com/r/macapps/s/psgVPRH1ir

@lra lra merged commit db744de into lra:master Aug 27, 2024
26 checks passed
@jtheletter jtheletter deleted the patch-1 branch August 27, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants