Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running Manjaro Linux (Plasma). Hardinfo didn't load the benchmarks for me, so I did a little digging, and found a ticket for it already. Since the issue didn't look too difficult, I decided to give it a shot, so here goes!
Loading
benchmark.so
beforedevices.so
fails, so make sure we loaddevices.so
first:devices.so
so it's always firstThe terminal output was similar to the linked issue below. With this PR, I'm able to see and run benchmarks using the GUI, with terminal output now looking like this:
The downside of this approach is that it's only possible to have one module loaded before all the rest, and the rest will still be in arbitrary order. Module priority list (or dependency lists) would solve this but this works fine, as long as none of the other modules depend on a module other than
devices.so
.Fixes #676
PS. This is my first contact with GLib, but at least the compiler is happy 😄