info struct bug Fixes, add tagged update fields #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tag was always included even when it didn't need to be. Now only include it when tag specified, flagged, or includes an icon. This messed up the existing update fields system. * The update fields system has been changed to allow updating by tag instead of the translated label. By label still works, however. I think it would be best to switch to using tags in the future. * info_flatten() calls flatten_shell_param() after flatten_group() which could cause a field name or tag to be used after it was freed. Created special free functions to handle this after all is used. Signed-off-by: Burt P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include it when tag specified, flagged, or includes an icon.
This messed up the existing update fields system.
instead of the translated label. By label still works, however.
I think it would be best to switch to using tags in the future.
which could cause a field name or tag to be used after it was freed.
Created special free functions to handle this after all is used.
[discussion] struct info free/no-free sets #411 would really be good here.