Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] logins configure roles too #250

Open
DorBreger opened this issue May 23, 2024 · 7 comments
Open

[Request] logins configure roles too #250

DorBreger opened this issue May 23, 2024 · 7 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@DorBreger
Copy link
Contributor

Is your feature request related to a problem? Please describe.
when using the login module I would like to add roles too.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Have another parameter of type list with all roles that will be granted to the login
Describe alternatives you've considered

Additional context

@DorBreger DorBreger added the enhancement New feature or request label May 23, 2024
@lowlydba
Copy link
Owner

Are you thinking server roles or database roles?

@DorBreger
Copy link
Contributor Author

Server

@lowlydba
Copy link
Owner

lowlydba commented May 25, 2024

That seems like a good fit! It may make sense to also add a module for defining server roles as well to complement this (#251)

@lowlydba lowlydba self-assigned this May 25, 2024
@lowlydba lowlydba removed their assignment Jun 2, 2024
@lowlydba
Copy link
Owner

lowlydba commented Jun 2, 2024

So my schedule is going to be crazy for a while, and I thought I'd have time to work on this but likely will not. I did start getting the initial logic down, if you want to use it as a head start on making a PR.

https://github.com/lowlydba/lowlydba.sqlserver/compare/add-roles-to-login?expand=1

@DorBreger
Copy link
Contributor Author

So my schedule is going to be crazy for a while, and I thought I'd have time to work on this but likely will not. I did start getting the initial logic down, if you want to use it as a head start on making a PR.

https://github.com/lowlydba/lowlydba.sqlserver/compare/add-roles-to-login?expand=1

Sure. I'm quite busy as well, but I will try to tackle this when I have time, it seems interesting, thanks for the help!

@DorBreger
Copy link
Contributor Author

seems like I need to be a collaborator for this link to work

@lowlydba
Copy link
Owner

Ah, sorry about that. Does this work? main...add-roles-to-login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants