Link real IMM_ROM_EXT into ROM_EXT #25686
Open
+869
−237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchiawei
requested review from
moidx,
a team and
timothytrippel
and removed request for
a team
lchiawei
force-pushed
the
link-main-imm
branch
from
d509d53 to
46031c0
Compare
Reconfigure ePMP in immutable ROM_EXT to remove executable permission on the immutable data segment. Now, ePMP will be reconfigured to the following layout before jumping to the mutable ROM_EXT: ``` * 6: MU_EXT ----- ---- * 7: MU_EXT TOR LX-R * 8: IM_EXT ----- ---- * 9: IM_EXT TOR LX-R * 10: VIRTUAL NAPOT L--R * 11: STACK NA4 L--- ``` MU_EXT stands for mutable part of rom_ext, and IM_EXT is the immutable part. Slot 10 will be empty if address translation is not enabled, and stack guard is added back to slot 11. Before jumping to Owner SW, all lock bits will be cleared, so all entries can be recycled by Owner SW. Owner SW will be placed at the same entries as before (2, 3, 4). Change-Id: Id9b6cd68cc24a5816d3e3dc8374b5533a7c6eb75 Signed-off-by: Yi-Hsuan Deng <[email protected]>
* Refine ld and .S file for IMM_ROM_EXT. * Update the hello-world IMM_ROM_EXT to access some data in .data and .bss sections to make sure the startup initialization is implemented correctly. Signed-off-by: Chia-Wei Liu <[email protected]>
lchiawei
force-pushed
the
link-main-imm
branch
from
46031c0 to
325292c
Compare
Remove calling imm_rom_ext_main in rom_ext_main, and use prebuilt IMM_ROM_EXT instead. Signed-off-by: Chia-Wei Liu <[email protected]>
* Add mechanism to select corresponding IMM_ROM_EXT sections when building ROM_EXT based on the exec_env * Add a new exec_env that is as same as silicon creator except an empty manifest to skip the signing phase when building IMM_ROM_EXT Signed-off-by: Chia-Wei Liu <[email protected]>
lchiawei
force-pushed
the
link-main-imm
branch
from
325292c to
59af18f
Compare
As now we always link IMM_ROM_EXT into ROM_EXT, the address of IMM_ROM_EXT's linker for slot A/B ROM_EXT should be adjusted. Apply similar solution from ROM_EXT's linker scripts on IMM_ROM_EXT ones. Also cleaned up the hello-world ROM code as we do not need them anymore. Signed-off-by: Chia-Wei Liu <[email protected]>
lchiawei
force-pushed
the
link-main-imm
branch
from
59af18f to
3f86086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly does the work about the IMM_ROM_EXT linking, including following commits:
imm_rom_ext_main()inrom_ext_main().exec_env. For silicon creator, also add a new exec_env that does not contain a manifest to skip the signing phase.The first two commits in this PR are authored by @sasdf and is included in #25294 and #25310. I will rebase my PR to ToT once they are merged.