Fix the gpio_stress_all with random reset #25657
Open
+54
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelocarvalhoLowRisc
requested review from
matutem
and removed request for
a team
marcelocarvalhoLowRisc
force-pushed
the
rnd_reset_debug
branch
14 times, most recently
from
ada03cb to
245aab3
Compare
|
Please could you squash all these commits together? |
marcelocarvalhoLowRisc
force-pushed
the
rnd_reset_debug
branch
5 times, most recently
from
a6b6d85 to
3e539ca
Compare
marcelocarvalhoLowRisc
force-pushed
the
rnd_reset_debug
branch
from
3e539ca to
eace0fe
Compare
marcelocarvalhoLowRisc
force-pushed
the
rnd_reset_debug
branch
from
eace0fe to
7d67ef6
Compare
rswarbrick
reviewed
Dec 17, 2024
hw/ip/gpio/dv/env/seq_lib/gpio_random_long_reg_writes_reg_reads_vseq.sv
Outdated
Show resolved
Hide resolved
matutem
reviewed
Dec 18, 2024
|
Thanks! |
Updates to the sequences to replace the wait_clk to wait_clks_or_rst. Signed-off-by: Marcelo Carvalho Faleiro de Almeida <[email protected]> Removed new lines Signed-off-by: Marcelo Carvalho Faleiro de Almeida <[email protected]> Remove new lines Just to fix the lint errors about new lines and spaces Signed-off-by: Marcelo Carvalho Faleiro de Almeida <[email protected]>
marcelocarvalhoLowRisc
force-pushed
the
rnd_reset_debug
branch
from
7d67ef6 to
88d88c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New fix for the stress_all_gpio testcase with random reset. Basically included new if(reset) checks into the sequences to skip the flow when a reset comes, and replaced the wait_clks task to wait_clks_or_rst. This makes the gpio test pass with a reasonable number of seeds. It's a temporally fix until we have the reset agent on place.