[manuf] Clean up device ID confirmation message #25508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug in DeviceId.update_base_id() - Add pretty-print of FT device ID - Fix typo in log message Signed-off-by: Noah Moroze <[email protected]>
Signed-off-by: Noah Moroze <[email protected]>
Signed-off-by: Noah Moroze <[email protected]>
nmoroze
force-pushed
the
orchestrator-msg-cleanup
branch
from
e4d0582 to
cdc1ae6
Compare
timothytrippel
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the DIN handling in the device ID to create a
Nonedefault and makes the CP confirmation message clearer. I also tossed in a few other small fixes/cleanups while I was in there.@timothytrippel LMK if this looks like what you had in mind!