Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick to earlgrey 1.0.0: [sival/aes] Add aes_force_prng_reseed_test and aes_prng_reseed_test #25441

Conversation

github-gcontributor
Copy link
Contributor

Manually created backport PR from PR #24574 to branch earlgrey_1.0.0.

@github-gcontributor github-gcontributor requested review from alees24 and removed request for a team November 27, 2024 23:27
@engdoreis engdoreis changed the base branch from master to earlgrey_1.0.0 November 29, 2024 11:29
@engdoreis
Copy link
Contributor

I changed the base branch from master to earlgrey_1.0.0, @github-gcontributor can you please fix the conflict so that we can merge it.

This commit introduces the AES PRNG reseed test (chip_sw_aes_prng_reseed)
and (chip_sw_aes_force_prng_reseed) and AES FORCE PRNG reseed, to handle the
reseed process by disabling entrpy complex and triggering PRNG reseed
accordingly to test the actual behavior of the AES module's PRNG reseeding in
ECB mode.

- Updated the test plan descriptions in `chip_aes_testplan.hjson` to match
  the implemented tests. Added missing test feature.
- Resoloved latest code suggestions provided in PR lowRISC#24574 and updated
  code with suggestions from other thread (using TRY and remove .c suffix
  in bazel tag).
- Single commit for a cleaner history.
- Resolve multiple commits.
- Manualy resolve conflict

See: hw/top_earlgrey/data/ip/chip_aes_testplan.hjson
Closes Issue lowRISC#24857
Closes Issue lowRISC#24899
PR lowRISC#24574

Signed-off-by: Varunkumar Trivedi <[email protected]>
(cherry picked from commit 06976d7)
@github-gcontributor github-gcontributor force-pushed the backport-24574-to-earlgrey_1.0.0 branch from d12df3b to 04d8308 Compare December 4, 2024 18:05
@github-gcontributor
Copy link
Contributor Author

I changed the base branch from master to earlgrey_1.0.0, @github-gcontributor can you please fix the conflict so that we can merge it.

Hi @engdoreis,
I am able to manually resolve the conflict.
Kindly proceed to merge the PR and let me know if there is any other step required to make the test part of the regression.

@github-gcontributor
Copy link
Contributor Author

Hi @engdoreis ,
Any thing on my side on this?

@engdoreis
Copy link
Contributor

Merging since the CI error is not related to this PR.

@engdoreis engdoreis merged commit f812cf5 into lowRISC:earlgrey_1.0.0 Dec 10, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants