[crypto] Adjust error handling in P-384. #25390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return a bad status code rather than a fault when the public key or signature is invalid (like P-256). Otherwise, OTBN would lock; it's better to fail gracefully on bad input. Signed-off-by: Jade Philipoom <[email protected]> (cherry picked from commit 1c9535d)
Now that we have the IMEM space for it, it makes sense to push point-validity checks closer to the use of the point in ECDSA verify and ECDH. This removes a lot of places where the validity check and point use are decoupled, which could lead to security holes. It also simplifies the code quite a bit and saves a chunk of code size. Signed-off-by: Jade Philipoom <[email protected]> (cherry picked from commit 810945a)
milesdai
approved these changes
Nov 26, 2024
moidx
approved these changes
Nov 27, 2024
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of #25329.