Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 bug fixes #356

Open
wants to merge 15 commits into
base: apiv2
Choose a base branch
from
Open

V2 bug fixes #356

wants to merge 15 commits into from

Conversation

bhattumang7
Copy link

I am fixing several bugs with this pull request.

  • When downloading the files, an error occurs about the encoding of files. I fixed that.
  • A warning about the escape sequence in the code that showed the utility logo was fixed.
  • An error occurred when sending an epub to Kindle if content with a significant length had "display: none" as styling. I changed it to "visibility: hidden" to avoid that problem.
  • Fixed an error where SB_THEME_FILE (override_v1.css) was missing from the manifest.
  • Fixed a bug where the table of contents was not building correctly for Kindle. The problem was that the ID for the 'navPoint' was blank, which was the problem.
  • Added a feature to download the images mentioned in the CSS file and included these files to manifest correctly with the correct type.
  • The files were UTF-8, but the meta tag did not mention the encoding, causing gibberish characters on the Kindle device.
  • Adjusted the CSS file override_v1.css so the final epub generated has correct code snippets.
  • Fixed a bug where the cover page does not appear correctly on the Kindle device. The cover image's "content=" in meta did not mention the correct ID in the list.

@bhattumang7
Fixed invalid escape sequence '\ ' error when showing orily/safari books
49f631e
@bhattumang7
Fixed UTF8 encoding error
9a046ea 
Fixed an error related to char map UTF 8
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode character '\U0001d719' in position 32547: character maps to <undefined>
@bhattumang7
Changing "display:none" to "visibility: non" to avoid error when send…
e6a2b11 
…ing to kindle
@bhattumang7
not adding SB_THEME_FILE to self.css was making it go missing from ma…
8b7fb01 
…nifest

- Not adding the custom theme to self.css was causing it go missing from the manifest. Corrected that. Also, adjusted the CSS download code to handle local file copy.
- Not having a try catch was not giving correct errors. Added that.
@bhattumang7
removed backup that was not needed
20e17ac
@bhattumang7
when the fragment in TOC is blank from orielly, blank ID were causing…
4121378 
… problem and table of content was not building
@bhattumang7
preparing a list of images referenced in the css
b951537
@bhattumang7
Started downloading images referenced in the css file
cd8b2bc
@bhattumang7
For the images in the Styles folder, the manifest did not have correc…
4245a2f 
…t images name and media type
@bhattumang7
added UTF-8 indicator to the HTML to get rid of the gibberish charac…
6e50c56 
…ters on kindle
@bhattumang7
adjusted the css with the latest file and removed the tags not needed
157a8a9
@bhattumang7
Fix an error where cover page was not visible on kindle because of in…
78a7644 
…correct cover page ID in content.opf
@bhattumang7
instead of cssutils using tinycss2.parse_stylesheet to get lsit of im…
5185f73 
…ages
@bhattumang7
removed extra line
1f1ba7f
@bhattumang7
Update requirements.txt
8719430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bhattumang7