Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monorepo): creating packages post-Lerna@7 #10623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achrinza
Copy link
Member

@achrinza achrinza commented Aug 4, 2024

Updates internal monorepo package creator to use npm install instead of lerna bootstrap.

This fix prevents the following error:

node ./bin/create-package.js packages/model
...
ERR! bootstrap The "bootstrap" command was removed by default in v7, and is no longer maintained.
ERR! bootstrap Learn more about this change at https://lerna.js.org/docs/legacy-package-management
 Command aborts (code 1 signal null): npx "lerna" "bootstrap" "--scope" "@loopback/model".
Error: Process 1192 exits with code 1 signal null
    at ChildProcess.<anonymous> (/home/user/Documents/git-repos/loopbackio/loopback-next/bin/create-package.js:61:11)
    at ChildProcess.emit (node:events:519:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Updates internal monorepo package creator to use `npm install` instead of `lerna bootstrap`.

see: https://lerna.js.org/docs/legacy-package-management
Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza force-pushed the fix/internal-package-create branch from 5e4fcba to 0294492 Compare August 4, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant