[WORKAROUND] fix(tsdocs): disable some repos to gen tsdocs #10223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhmlau
commented
Dec 6, 2023
| LernaPackage, | ||
| getPackagesWithTsDocs, |
There was a problem hiding this comment.
this change seems to be introduced by running npm run lint:fix 🤷
achrinza
approved these changes
Dec 6, 2023
Comment on lines
+70
to
+80
| if ( | ||
| pkg.name === '@loopback/typeorm' || | ||
| pkg.name === '@loopback/boot' || | ||
| pkg.name === '@loopback/express' || | ||
| pkg.name === '@loopback/repository' || | ||
| pkg.name === '@loopback/service-proxy' | ||
| ) | ||
| continue; |
There was a problem hiding this comment.
nit: can we add a comment linking back to the Github issue?
Signed-off-by: dhmlau <[email protected]>
dhmlau
force-pushed
the
disable-tsdocs
branch
from
3086797
to
a5e5b10
Compare
Pull Request Test Coverage Report for Build 7115768200
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10205
Currently publishing the release for loopback-next modules is blocked due to the problem described in #10205. I had tried to isolate the problem to identify where could go wrong but failed. Given that we weren't able to publish for 2 months, it might be a workable temp fix to remove the "problematic repos" when generating the tsdocs. 1/ our APIs are relatively stable, and 2/ there are fixes that went in that we should publish.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈