Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployer permission override #1007

Closed
wants to merge 2,875 commits into from
Closed

Deployer permission override #1007

wants to merge 2,875 commits into from

Conversation

pathornteng
Copy link
Contributor

@pathornteng pathornteng commented Apr 17, 2019 •
edited
Loading

  • I added unit tests for any code that added
  • I updated the CHANGELOG.md
  • All IP is original and not copied from another source
  • I assign all copyright to Loom Network for the code in the pull request

Issue: #981
go-loom: loomnetwork/go-loom#355

aupiff and others added 30 commits March 18, 2019 17:33
@aupiff
Merge pull request #864 from loomnetwork/testing
c07eb87 
Testing & Candidate Updates
@pathornteng
merge master
6262d37
@pathornteng
fix unmerged Makefile
eb984e0
@pathornteng
add chainconfig config
511d71e
@pathornteng
add e2e tests
700d7ca
@suhasagg
Error Threshold Test
88bdb54
@mattkanwisher
Merge pull request #863 from loomnetwork/golangcilint
ce7109d 
Golangcilint
@aupiff
creating migration functions skeleton
681bdc7
@aupiff
migrating state and candidates
8bf5a08
@aupiff
adding statistics to migration
6beae49
@aupiff
adding delegation migration
5a0540b
@aupiff
creating basic initialize function
91dbc5f
@aupiff
finalizing dposv3.Initialize function
5dbef8e
@pathornteng
add FeatureEnabled to Context
b0ed247
@suhasagg
golangcilint configuration file
3e4689a
@suhasagg
Print Bugs spotted by
44876c1 
Golangcilint
@mattkanwisher
Merge pull request #867 from loomnetwork/golangciconfigurationfile
6b1d736 
golangcilint configuration file
@mattkanwisher
fix compilations
9aa03c5
@mattkanwisher
Merge pull request #868 from loomnetwork/fix-compilations
1d79743 
fix compilations
@pathornteng
fix as comments
443e773
@pathornteng
fix failed e2e test
65cbcce
@pathornteng
only calculate Percentage for pending feature
da87a7d
@enlight
Cleanup
d2e9423 
- Inline enableFeature
- Add missing request validation checks
- Make getParams return default initialized struct when no params are set
- Fix attempts to read unarmshaled struct on proto.Unmarshal error
- Add comments
@aupiff
starting migration unit tests
a2c90df
@aupiff
updating migration tests
a057330
@pathornteng
fix failed test
871408b
@aupiff
minor changes
f17a138
@enlight
Reduce number of calls to the DPOSv2 contract & pull out less data
6f7236f 
Really the current validator set should be available through
Validators() on the contract context, but that doesn't appear to be
hooked up to DPOSv2, only v1, so we have to make a direct call into the
DPOSv2 contract for now.
@enlight
Tweak keys & permissions
03f2be9
@enlight
Switch back to go-loom master
704af7d
aupiff and others added 13 commits April 14, 2019 21:41
@aupiff
adding a tiny bit more to the docs
741c8e4
@enlight
Tweak linter settings (#999)
26334fd 
* Restrict line length to 120 chars
* Lower linter error threshold to 136
@gakonst
Merge pull request #998 from loomnetwork/dpos-docs
33fc2fc 
dPoS docs & referral improvements
@gakonst
Load dposv3 when set in the loom.yml
dc89cb2
@gakonst
Fix comment
fd5010b
@gakonst
Merge pull request #1000 from loomnetwork/load-dposv3-version
3a5bbef 
Load dposv3 when set in the loom.yml
@enlight
Fix cluster readiness check in e2e test runner (#1002)
e50c64f 
* Fix cluster readiness check in e2e test runner

Previous implementation didn't actually work properly.

* Increase max retries to 5 while waiting for nodes to start up

coin-2 really doesn't like starting up in timely fashion sometimes.
@enlight
Update changelong for build 963
354bc7b
@Sriep @enlight
remove superfluous error message
2acefe3
@Sriep @enlight
Fix websocket concurrency issues in Eth JSON-RPC interface & issues f…
8f52d43 
…rom PR 886 (#1001)

- Fix review issues from #886
- Write websocket response in a separate go-routine, to avoid concurrency issues.
@pathornteng
add default deployer permission flags
09cf0bc
@pathornteng
add more unit tests
bd8d72c
@pathornteng
change go-loom branch
b68b845
@pathornteng pathornteng self-assigned this Apr 17, 2019
pathornteng and others added 3 commits April 17, 2019 16:35
@pathornteng
add new e2e test
173ead8
@adyromantika
Compress and move test data (#1008)
7ee31b8 
* Compress and move test data

* Only include logs

* Reorder
@pathornteng
clean up
e16f824
enlight
enlight requested changes Apr 17, 2019
View reviewed changes
cmd/loom/deployerwhitelist/cmd.go Outdated Show resolved Hide resolved
cmd/loom/deployerwhitelist/cmd.go Outdated Show resolved Hide resolved
builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated Show resolved Hide resolved
builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated Show resolved Hide resolved
builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated Show resolved Hide resolved
builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated Show resolved Hide resolved
cmd/loom/deployerwhitelist/cmd.go Outdated Show resolved Hide resolved
throttle/deployer-middleware.go Outdated Show resolved Hide resolved
adyromantika and others added 3 commits April 17, 2019 23:30
@adyromantika @enlight
Fix log file extraction on Jenkins OSX job (#1009)
491028d 
Wrong file name for OSX.
@pathornteng @enlight
Check minimum build version before enabling feature flag (#982)
e89b92f 
Force the ChainConfigManager to panic if it tries to enable a feature that's not supported by the current build. This should safely prevent the node from processing any further blocks in case a feature it doesn't support is activated by the rest of the chain. To make this work features now have a minimum build number associated with them, which must be specified by the ChainConfig contract owner when adding new features.

The new functionality is not behind a feature flag, so once this is deployed to production new features can't be added until the whole cluster upgrades to a new build.
@suhasagg @enlight
Refactoring for coin commands migration to loomchain (#996)
4dfcbfd 
* URI support in e2e test runner
* URI support in coin tests
* Coin command migration to go-loom
* URI FLag support in sendtx
* URI support in util.go
@pathornteng pathornteng changed the title Default deployer permission Deployer permission override Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enlight enlight enlight requested changes

Assignees

@pathornteng pathornteng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pathornteng @enlight @mattkanwisher @aupiff @suhasagg @Sriep @gakonst @ParthDesai @phoorichet @adyromantika