Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(metrics): add pvc name to volume metrics #767

Merged
merged 2 commits into from
Aug 21, 2023
Merged

doc(metrics): add pvc name to volume metrics #767

merged 2 commits into from
Aug 21, 2023

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang
doc(metrics): add pvc name to volume metrics
d200f74 
ref: 5297

Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang c3y1huang self-assigned this Aug 18, 2023
@c3y1huang c3y1huang mentioned this pull request Aug 18, 2023
Closed
innobead
innobead requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update to 1.5 and 1.4.

@c3y1huang
doc(metrics): add pvc name to volume metrics
00f6087 
Backported to v1.4.4 and v1.5.2

ref: 5297

Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang c3y1huang marked this pull request as ready for review August 21, 2023 08:49
@c3y1huang c3y1huang requested a review from a team as a code owner August 21, 2023 08:49
@c3y1huang c3y1huang requested a review from innobead August 21, 2023 08:50
@innobead innobead merged commit 2b2c27a into longhorn:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c3y1huang @innobead