WIP

Signed-off-by: Derek Su <[email protected]>

go.mod

@@ -7,6 +7,7 @@ toolchain go1.23.3
 require (
 	github.com/0xPolygon/polygon-edge v1.3.3
 	github.com/google/uuid v1.6.0
+	github.com/jinzhu/copier v0.4.0
 	github.com/longhorn/backupstore v0.0.0-20241124092526-138305866a87
 	github.com/longhorn/go-common-libs v0.0.0-20241124035508-d6221574e626
 	github.com/longhorn/go-spdk-helper v0.0.0-20241124090314-c396ae715a7f

go.sum

@@ -41,6 +41,8 @@ github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
 github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
+github.com/jinzhu/copier v0.4.0 h1:w3ciUoD19shMCRargcpm0cm91ytaBhDvuRpz1ODO/U8=
+github.com/jinzhu/copier v0.4.0/go.mod h1:DfbEm0FYsaqBcKcFuvmOZb218JkPGtvSHsKg8S8hyyg=
 github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
 github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=

pkg/spdk/engine.go

@@ -8,8 +8,10 @@ import (
 	"sync"
 	"time"
 
+	"github.com/jinzhu/copier"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
+
 	grpccodes "google.golang.org/grpc/codes"
 	grpcstatus "google.golang.org/grpc/status"
 
@@ -662,13 +664,42 @@ func (e *Engine) getWithoutLock() (res *spdkrpc.Engine) {
 	return res
 }
 
+func areNvmeSubsystemsEqual(old, new *api.NvmeSubsystem) bool {
+	if len(old.Paths) != len(old.Paths) {
+		return false
+	}
+	for oldPathName, oldPath := range old.Paths {
+		newPath, ok := new.Paths[oldPathName]
+		if !ok {
+			return false
+		}
+		if oldPath.Trtype != newPath.Trtype ||
+			oldPath.Traddr != newPath.Traddr ||
+			oldPath.Trsvcid != newPath.Trsvcid ||
+			oldPath.SrcAddr != newPath.SrcAddr ||
+			oldPath.State != newPath.State {
+			return false
+		}
+
+	}
+	return true
+}
+
 func (e *Engine) ValidateAndUpdate(spdkClient *spdkclient.Client) (err error) {
 	updateRequired := false
 
+	existingNvemSubsystem := api.NvmeSubsystem{}
+	copier.Copy(&existingNvemSubsystem, &e.NvmeSubsystem)
+
 	e.Lock()
 	defer func() {
 		e.Unlock()
 
+		if !areNvmeSubsystemsEqual(&existingNvemSubsystem, &e.NvmeSubsystem) {
+			e.log.Infof("Found difference between existing nvme subsystem %+v and updated nvme subsystem %+v during ValidateAndUpdate", existingNvemSubsystem, e.NvmeSubsystem)
+			updateRequired = true
+		}
+
 		if updateRequired {
 			e.UpdateCh <- nil
 		}