Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev work #187

Merged
merged 9 commits into from
Jul 21, 2024
Merged

dev work #187

merged 9 commits into from
Jul 21, 2024

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Jul 14, 2024 •
edited
Loading

this pr closes #181, closes #182, closes #183

  • Make sure tests upon PR will run
  • Update workflow versions
  • Fix failing tests
    • change elb >> s3Access to prevent need for specific files format
    • fix format of OSD objects
    • split datasource and resource KB Object tests
      • DELETE is not supported which caused failure in the second running test
      • so splitting them resolves it
    • increase tests timeout (default 10m is sometimes not enough)
    • add missing env variable needed for s3 fetcher tests to pass

@8naama 8naama mentioned this pull request Jul 21, 2024
Merged
@8naama 8naama requested review from ralongit and yotamloe July 21, 2024 09:40
@8naama 8naama requested a review from ralongit July 21, 2024 11:27
ralongit
ralongit approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:)

@8naama 8naama merged commit c2e3688 into master Jul 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralongit ralongit ralongit approved these changes

@yotamloe yotamloe Awaiting requested review from yotamloe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@8naama @ralongit