Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests and improve workflow #12

Closed
wants to merge 11 commits into from
Closed

fix tests and improve workflow #12

wants to merge 11 commits into from

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Mar 28, 2024

this PR closes: #10

  • Squash all commits from dev-workflows to separate deploy.yaml and tests.yaml workflows
  • Replace httpreety with responses
    • caused unnecessary errors due to open issue 466 in the package
    • had issue testing locally due to urllib3 version issue in mac
    • easier to troubleshoot - errors are more detailed
  • Fix deadlock in the shipping tests
    • add test parameter as true/false to APIManager to stop shipping and fill the queue before the process is killed and queue doesn't get filled up
    • change queue.get() >> queue.get(False)

@8naama 8naama closed this Jul 8, 2024
@8naama 8naama deleted the clean-dev-workflows branch August 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant