Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-44180 - Changes for alert eval #23

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

yasmin-tr
Copy link

@yasmin-tr yasmin-tr commented Jun 2, 2024

What is this feature?

Changes required for logz alert evaluation integration:

  • Added the logzio_alerts_route_url in defaults.ini so it can be configured as part of the image variables, instead of custom.ini file, as it is based on environment
  • Added metrics alerts Query-Source header in the alert evaluation api.
  • In elasticsearch client fix to send the correct querySource

Why do we need this feature?
Alert evaluation in logz

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

* Added the logzio_alerts_route_url in defaults.ini so it can be configured as part of the image variables, instead of custom.ini file, as it is based on environment
* Added metrics alerts Query-Source header in the alert evaluation api.
* In elasticsearch client fix to send the correct querySource
@yasmin-tr
Copy link
Author

run-test

@yasmin-tr yasmin-tr merged commit 8405d85 into v10.4.x-logzio Jun 3, 2024
10 of 16 checks passed
@yasmin-tr yasmin-tr deleted the DEV-44180-changes-for-alert-eval branch September 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant