DEV-43932 Grafana upgrade code migration - Home dashboard #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasmin-tr
reviewed
Mar 28, 2024
| @@ -43,7 +43,7 @@ export class OrgDetailsPage extends PureComponent<Props> { | |||
| render() { | |||
| const { navModel, organization } = this.props; | |||
| const isLoading = Object.keys(organization).length === 0; | |||
| const canReadOrg = contextSrv.hasPermission(AccessControlAction.OrgsRead); | |||
| const canReadOrg = false; // LOGZ.IO GRAFANA CHANGE | |||
There was a problem hiding this comment.
No ticket reference? 😅 What functionality is it part of?
Btw with no original ticket I would put one for a new ticket perhaps or at least the ticket your merging this part of
ifatregev
reviewed
Mar 28, 2024
| if ((global as any).parent.__logzio__) { | ||
| logzioServices = (global as any).parent.__logzio__.services || {}; | ||
| } | ||
| export let logzioDeprecatedAngularServices: any = (global as any).parent.__logzio__.services; |
There was a problem hiding this comment.
usesd? it is the same as 'logzioServices'
ifatregev
reviewed
Mar 28, 2024
| export let logzioDeprecatedAngularServices: any = {}; | ||
| export let logzioServices: any = {}; | ||
| export let logzioConfigs: any = {}; | ||
| export let productLoaded: any = {}; |
ifatregev
approved these changes
Mar 28, 2024
ifatregev
changed the title
copyhold
commented
Mar 28, 2024
There was a problem hiding this comment.
productLoaded call moved to the AppWrapper.tsx and is called directly from window object
__logzio__.services is already a Proxy and therefore always properly polulated.
logzio.configs is a json object that could be empty during iframe loading - wrap it with Proxy to always access up to date values
copyhold
commented
Mar 28, 2024
copyhold
commented
Mar 28, 2024
copyhold
commented
Mar 28, 2024
There was a problem hiding this comment.
hide organization from enduser
…slack Grafana contact point config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIgrated: