Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add redis ping interval #6819

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented Nov 18, 2024

Summary

  1. Add a Redis ping interval to prevent idle connections from being disconnected by Azure. For more details, refer to the Azure documentation on idle timeout.
  2. Add trySafe wrapper to the WellKnown cache getter method. Incase of any Redis connection failure, it should not affect the Logto core functionality.

Testing

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

add redis ping interval
Copy link

github-actions bot commented Nov 18, 2024

COMPARE TO master

Total Size Diff 📈 +263 Bytes

Diff by File
Name Diff
packages/core/src/caches/index.ts 📈 +213 Bytes
packages/core/src/caches/well-known.ts 📈 +50 Bytes

add trySafe to wellknown cache
@github-actions github-actions bot added size/s and removed size/xs labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants