Skip to content

Commit

Permalink
Fix bug when number of (solve steps % options.save_every) == 0 (#83)
Browse files Browse the repository at this point in the history
* Fix bug when number of solve steps % save_every == 0
  • Loading branch information
loganbvh authored Jun 28, 2024
1 parent a495d03 commit 76013e2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion tdgl/solver/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,6 @@ def save_step(step):
self.logger.warning(msg.format("Cancelling"))
cancelled = True
break
if save:
if save and (i % self.options.save_every):
save_step(i)
return not cancelled
6 changes: 3 additions & 3 deletions tdgl/solver/solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ def update(
(current_A_applied - prev_A_applied) / dt,
self.normalized_directions,
)
if xp.any(xp.absolute(dA_dt) > 0):
if not xp.allclose(current_A_applied, self.current_A_applied):
# Update the link exponents only if the applied vector potential
# has actually changed.
operators.set_link_exponents(current_A_applied)
Expand All @@ -642,10 +642,10 @@ def update(
self.current_A_applied = current_A_applied

# Update the value of epsilon
epsilon = self.epsilon
if self.dynamic_epsilon:
epsilon = self.epsilon = self.update_epsilon(time)
self.epsilon = self.update_epsilon(time)

epsilon = self.epsilon
old_sq_psi = xp.absolute(psi) ** 2
screening_error = np.inf
A_induced_vals = [A_induced]
Expand Down
2 changes: 1 addition & 1 deletion tdgl/version.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version_info__ = (0, 8, 2)
__version_info__ = (0, 8, 3)
__version__ = ".".join(map(str, __version_info__))


Expand Down

0 comments on commit 76013e2

Please sign in to comment.