Basic August support #506
Merged
Basic August support #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokoeka
reviewed
Aug 9, 2023
src/resources/2023/AugustScepter.ts
Outdated
| * @returns Today's august scepter skill | ||
| */ | ||
| export function todaysSkill(): Skill { | ||
| return SKILLS[today() - 1]; |
There was a problem hiding this comment.
Is there a reason for doing it this way rather than just referring to the skillnumber minus a constant (7451)? Would mean we dont have to list out all the skill names, which feels neater to me?
There was a problem hiding this comment.
Yeah we can do that. I still think we should export the constant.
Because you're doing arithmetic, you'll want to do like toSkill((7451 + today()).toFixed(0)) because of dumb int vs float stuff
burningbman
approved these changes
Aug 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
Basic August support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.