added version compatibility check

lmenezes · Jan 15, 2016 · 250ede7 · 250ede7
1 parent 64f0bba
commit 250ede7
Show file tree

Hide file tree

Showing 5 changed files with 70 additions and 0 deletions.
diff --git a/_site/dist/kopf.js b/_site/dist/kopf.js
@@ -1226,6 +1226,24 @@ kopf.controller('GlobalController', ['$scope', '$location', '$sce', '$window',
 
     $scope.modal = new ModalControls();
 
+    $scope.$watch(
+        function() {
+          return ElasticService.cluster;
+        },
+        function(newValue, oldValue) {
+          var version = ElasticService.getVersion();
+          if (version && version.isValid()) {
+            var major = version.getMajor();
+            if (major != parseInt($scope.version.charAt(0))) {
+              AlertService.warn(
+                  'This version of kopf is not compatible with your ES version',
+                  'Upgrading to newest supported version is recommeded'
+              );
+            }
+          }
+        }
+    );
+
     $scope.getTheme = function() {
       return ExternalSettingsService.getTheme();
     };
@@ -4657,6 +4675,10 @@ kopf.factory('ElasticService', ['$http', '$q', '$timeout', '$location',
       }
     };
 
+    this.getVersion = function() {
+      return this.version;
+    };
+
     this.getHost = function() {
       return this.isConnected() ? this.connection.host : '';
     };

diff --git a/src/kopf/controllers/global.js b/src/kopf/controllers/global.js
@@ -7,6 +7,24 @@ kopf.controller('GlobalController', ['$scope', '$location', '$sce', '$window',
 
     $scope.modal = new ModalControls();
 
+    $scope.$watch(
+        function() {
+          return ElasticService.cluster;
+        },
+        function(newValue, oldValue) {
+          var version = ElasticService.getVersion();
+          if (version && version.isValid()) {
+            var major = version.getMajor();
+            if (major != parseInt($scope.version.charAt(0))) {
+              AlertService.warn(
+                  'This version of kopf is not compatible with your ES version',
+                  'Upgrading to newest supported version is recommeded'
+              );
+            }
+          }
+        }
+    );
+
     $scope.getTheme = function() {
       return ExternalSettingsService.getTheme();
     };

diff --git a/src/kopf/services/elastic.js b/src/kopf/services/elastic.js
@@ -142,6 +142,10 @@ kopf.factory('ElasticService', ['$http', '$q', '$timeout', '$location',
       }
     };
 
+    this.getVersion = function() {
+      return this.version;
+    };
+
     this.getHost = function() {
       return this.isConnected() ? this.connection.host : '';
     };

diff --git a/tests/jasmine/global.tests.js b/tests/jasmine/global.tests.js
@@ -108,4 +108,25 @@ describe('GlobalController', function() {
         expect(this.ElasticService.connect).toHaveBeenCalledWith('http://thishost:4321');
       });
 
+  it('should warn if not supported version is found', function() {
+    this.ElasticService.getVersion = function(){};
+    spyOn(this.ElasticService, 'getVersion').andReturn(new Version('1.0.0'));
+    spyOn(this.AlertService, 'warn').andReturn('');
+    this.ElasticService.cluster = '';
+    this.scope.$digest();
+    expect(this.AlertService.warn).toHaveBeenCalledWith(
+        'This version of kopf is not compatible with your ES version',
+        'Upgrading to newest supported version is recommeded'
+    );
+  });
+
+  it('should NOT warn if supported version is found', function() {
+    this.ElasticService.getVersion = function(){};
+    spyOn(this.ElasticService, 'getVersion').andReturn(new Version('2.0.0'));
+    spyOn(this.AlertService, 'warn').andReturn('');
+    this.ElasticService.cluster = '';
+    this.scope.$digest();
+    expect(this.AlertService.warn).not.toHaveBeenCalledWith();
+  });
+
 });
diff --git a/tests/jasmine/services/elastic.tests.js b/tests/jasmine/services/elastic.tests.js
@@ -688,4 +688,9 @@ describe("ElasticService", function() {
     expect(callbacks.error).toHaveBeenCalledWith({notreallyusingtheresponse:{}});
   });
 
+  it("should return the correct versiom", function() {
+    elasticService.setVersion('1.2.0');
+    expect(elasticService.getVersion().getValue()).toEqual('1.2.0');
+  });
+
 });