[MLIR][ONNX] Add support for onnx.scan op #3516
Open
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
2 times, most recently
from
39fe0ae
to
8d7cde2
Compare
|
Might be a good idea to either run an e2eshark op test or a custom test case with a contrived graph "loop body" just to make sure this actually runs and is consistent with onnxruntime. Sometimes the PrimLoopOp lowers to linalg but IREE is unable to execute it due to problems with mutability in tensors. |
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
from
8d7cde2
to
ec91723
Compare
This commit lowers onnx.scan op to torch.prim.Loop op and adds the lowering in the onnx pipeline. Signed-Off-by: Gaurav Shukla <[email protected]>
Shukla-Gaurav
force-pushed
the
gaurav/scanop
branch
from
ec91723
to
6140c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit lowers onnx.scan op to torch.prim.Loop op and adds the lowering in the onnx pipeline.