Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lklfuse: disable fuse lookup / attr cache and use lkl st_ino #543

Merged
merged 2 commits into from
Jun 4, 2024
Merged

lklfuse: disable fuse lookup / attr cache and use lkl st_ino #543

merged 2 commits into from
Jun 4, 2024

Conversation

ddiss
Copy link

@ddiss ddiss commented Jun 4, 2024

First couple of minor changes while working through some xfstests failures.

The following changes since commit fc0d27b8b37c089352a47d60ad44829a2ad63a4e:

  lklfuse: update to libfuse3 (2024-05-30 20:04:01 +1000)

are available in the Git repository at:

  https://github.com/ddiss/linux libfuse3_xfstests

for you to fetch changes up to b8618cd3c65eec363c0b6052fbf7647952fcba98:

  lklfuse: enable fuse_config.use_ino (2024-06-04 14:32:52 +1000)

----------------------------------------------------------------
David Disseldorp (2):
      lklfuse: disable fuse lookup and attr caches
      lklfuse: enable fuse_config.use_ino

 tools/lkl/lklfuse.c | 7 +++++++
 1 file changed, 7 insertions(+)

ddiss added 2 commits June 4, 2024 05:56
@ddiss
lklfuse: disable fuse lookup and attr caches
d00ad61 
As found by xfstests generic/002, fuse attr caching appears to be broken
in that it doesn't invalidate/update st_nlink following a link or
unlink, instead returning a stale value.
Regardless, there's no need to enable fuse caching, given that lkl
provides its own regular dcache.

Signed-off-by: David Disseldorp <[email protected]>
@ddiss
lklfuse: enable fuse_config.use_ino
b8618cd 
lkl provides valid st_ino values via the getattr and readdir hooks, so
it makes sense to have fuse use them.

Signed-off-by: David Disseldorp <[email protected]>
tavip
tavip approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@tavip tavip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks David!

@tavip tavip merged commit 7f7bc5f into lkl:master Jun 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tavip tavip tavip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddiss @tavip