Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cptofs: allow to override owner/group when copying files #532

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Mic92
Copy link

@Mic92 Mic92 commented Oct 6, 2023

cptofs is useful to write images without using virtual machines or having root access. This option allows to also write content as a different owner/group.

tools/lkl/cptofs.c Outdated Show resolved Hide resolved
@Mic92 Mic92 force-pushed the owner-group branch 2 times, most recently from b5be4e9 to 06d0b45 Compare October 6, 2023 14:47
Copy link
Member

@tavip tavip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Mic92 !

@tavip
Copy link
Member

tavip commented Oct 11, 2023

@Mic92 sorry for catching this late, there are a few coding style issues.

cptofs is useful to write images without using virtual machines or having root access.
This option allows to also write content as a different owner/group.

Signed-off-by: Jörg Thalheim <[email protected]>
@Mic92
Copy link
Author

Mic92 commented Oct 11, 2023

Should be fine now:

$ scripts/checkpatch.pl tools/lkl/cptofs.c
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#1: FILE: tools/lkl/cptofs.c:1:
+#ifdef __FreeBSD__

total: 0 errors, 1 warnings, 693 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

tools/lkl/cptofs.c has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

@tavip tavip merged commit 3023e6f into lkl:master Oct 11, 2023
12 of 13 checks passed
@Mic92 Mic92 deleted the owner-group branch October 12, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants