Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy filter syntax in li-document-search base filters breaking change #937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Legacy filter syntax in li-document-search base filters breaking change #937

wants to merge 1 commit into from

Conversation

robinbisping
Copy link
Contributor

@robinbisping robinbisping requested a review from JordiVM December 17, 2024 17:13
@JordiVM JordiVM force-pushed the release-2025-01-document-search-base-filter branch from 9d5e1fd to a478e11 Compare December 17, 2024 17:15
JordiVM
JordiVM approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@JordiVM JordiVM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to rebase manually since I was also changing this file.

Could you add the PRs where we introduce the breaking changes, CSO said they liked to have them handy. And I couldn't find some of them.

@marcbachmann
Copy link
Member

Could you add the PRs where we introduce the breaking changes, CSO said they liked to have them handy. And I couldn't find some of them.

This would be this change
https://docs.livingdocs.io/guides/editor/filter-migration/#migration-examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordiVM JordiVM JordiVM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robinbisping @marcbachmann @JordiVM