Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Get to 100% test coverage #639

Merged
merged 3 commits into from
Mar 19, 2024
Merged

test: Get to 100% test coverage #639

merged 3 commits into from
Mar 19, 2024

Conversation

victorges
Copy link
Member

@victorges victorges commented Mar 15, 2024

What does this pull request do? Explain your changes. (required)
This is just to get back to 100% coverage on BondingManager and Manager code by checking an unexercised code path.

Specific updates (required)

  • Add test for invalid treasury cut rate
  • Add test for Manager.whenSystemNotPaused

How did you test each of these updates (required)
yarn test

Does this pull request close any open issues?
No.

Checklist:

  • README and other documentation updated
  • All tests using yarn test pass

@victorges victorges changed the title test/unit: Add test case for invalid treasury cut rate value test: Get to 100% test coverage Mar 15, 2024
@victorges
Copy link
Member Author

🥳
Screenshot 2024-03-15 at 17 04 22

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (3966c9d) to head (bde5baa).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##               delta         #639         +/-   ##
====================================================
+ Coverage   99.61861%   100.00000%   +0.38139%     
====================================================
  Files             29           29                 
  Lines           1311         1311                 
  Branches         218          218                 
====================================================
+ Hits            1306         1311          +5     
+ Misses             5            0          -5     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3966c9d...bde5baa. Read the comment docs.

see 1 file with indirect coverage changes

@yondonfu yondonfu self-requested a review March 18, 2024 15:25
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@victorges victorges merged commit 57b7c63 into delta Mar 19, 2024
5 checks passed
@victorges victorges deleted the vg/fix/test-coverage branch March 19, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants