[delta-audit] treasury: Avoid overriding vote of non self-bonding accounts #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
force-pushed
the
vg/fix/c4-audit-96-206
branch
from
c8d2e9f
to
d28e09a
Compare
victorges
changed the title
victorges
changed the title
2 tasks
2 tasks
yondonfu
reviewed
Sep 22, 2023
victorges
added a commit
that referenced
this pull request
Sep 27, 2023
…ounts (#626) * treasury: Make consistent checks for isTranscoder * test/treasury: Add a unit test to the new logic * treasury: Fix weird variable names
victorges
added a commit
that referenced
this pull request
Oct 11, 2023
…ounts (#626) * treasury: Make consistent checks for isTranscoder * test/treasury: Add a unit test to the new logic * treasury: Fix weird variable names
victorges
added a commit
that referenced
this pull request
Oct 11, 2023
…ounts (#626) * treasury: Make consistent checks for isTranscoder * test/treasury: Add a unit test to the new logic * treasury: Fix weird variable names
victorges
added a commit
that referenced
this pull request
Oct 11, 2023
…ounts (#626) * treasury: Make consistent checks for isTranscoder * test/treasury: Add a unit test to the new logic * treasury: Fix weird variable names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This fixes a finding from the audit regarding on overriding votes. It addresses the problem of delegating to a non-transcoder account and then overriding their votes imprperly.
The known corner cases that can trigger this inconsistency are:
Specific updates (required)
How did you test each of these updates (required)
yarn testto be deployed on devnetDoes this pull request close any open issues?
Fixes:
Checklist:
yarn testpass